Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mt8186/v0.2 #8556

Closed
Closed

Conversation

barry-waves
Copy link
Contributor

waves: store config blob in a cache in waves.c

Store/apply config blob in a cache to avoid that
cfg.data will be released after prepare.

Copy link
Contributor

@johnylin76 johnylin76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zames-Chang Cherry-picked from main #8448

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barry-waves @johnylin76 CI does not test this code, I assume you have run some validation with this PR ?

@johnylin76
Copy link
Contributor

@barry-waves @johnylin76 CI does not test this code, I assume you have run some validation with this PR ?

@Zames-Chang could you help on that? Thanks

@barry-waves
Copy link
Contributor Author

Hi @lgirdwood ,
I only run some test cases for the issue which the patch fixed

@lgirdwood
Copy link
Member

@barry-waves some conflicts.

@barry-waves
Copy link
Contributor Author

Hi lgirdwood,
I have resolved those conflicts and also run some test cases.

@Zames-Chang
Copy link

This branch cannot be rebased due to conflicts

@barry-waves
Copy link
Contributor Author

Hi Zames-Chang,
How can I fix the conflicts? Could I fix the conflicts on github? Thank you.

src/audio/module_adapter/module/waves.c Outdated Show resolved Hide resolved
if (!response) {
comp_err(dev, "cadence_codec_init() failed to allocate %d bytes for response",
waves_codec->response_max_bytes);
return -ENOMEM;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another leak here

src/audio/module_adapter/module/waves.c Outdated Show resolved Hide resolved
@Zames-Chang
Copy link

I don't know why Github does not allow me to merge. I cherry-pick your change locally but it seem like it does not have merge conflict.

I will use command line to merge your change after you resolve lyakh comment.

@lgirdwood
Copy link
Member

I don't know why Github does not allow me to merge. I cherry-pick your change locally but it seem like it does not have merge conflict.

I will use command line to merge your change after you resolve lyakh comment.

There are branch protection rules. @thesofproject/mediatek owns the target branch so pls make check the branch rules, it could be a rule needs updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants