-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mt8186/v0.2 #8556
Mt8186/v0.2 #8556
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zames-Chang Cherry-picked from main #8448
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@barry-waves @johnylin76 CI does not test this code, I assume you have run some validation with this PR ?
@Zames-Chang could you help on that? Thanks |
Hi @lgirdwood , |
@barry-waves some conflicts. |
Hi lgirdwood, |
This branch cannot be rebased due to conflicts |
Hi Zames-Chang, |
if (!response) { | ||
comp_err(dev, "cadence_codec_init() failed to allocate %d bytes for response", | ||
waves_codec->response_max_bytes); | ||
return -ENOMEM; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another leak here
I don't know why Github does not allow me to merge. I cherry-pick your change locally but it seem like it does not have merge conflict. I will use command line to merge your change after you resolve lyakh comment. |
There are branch protection rules. @thesofproject/mediatek owns the target branch so pls make check the branch rules, it could be a rule needs updated. |
3bfa1ef
to
770a17d
Compare
770a17d
to
e4f8104
Compare
waves: store config blob in a cache in waves.c
Store/apply config blob in a cache to avoid that
cfg.data will be released after prepare.