Tools: Tune: Add tplg2 support to dcblock setup tool #8122
Conversation
singalsu
force-pushed
the
dcblock_update_setup_tool
branch
from
a509d24 to
2e26222
Compare
|
|
||
| %% Settings | ||
| bits_R = 32; %Q2.30 | ||
| qy_R = 30; | ||
|
|
||
| if nargin < 2 | ||
| endian = 'little' | ||
| endif | ||
| endian = 'little'; |
There was a problem hiding this comment.
bits_R looks like unused.
There was a problem hiding this comment.
Yep, I can remove. Easy to add back if would be needed again.
tools/tune/dcblock/example_dcblock.m
Outdated
|
|
||
| % Set the parameters here | ||
| tplg_fn = "../../topology/topology1/m4/dcblock_coef_default.m4" % Control Bytes File | ||
| tplg1_fn = "../../topology/topology1/m4/dcblock_coef_default.m4" % Control Bytes File |
There was a problem hiding this comment.
Please include a semicolon in all parameter settings if you do not intend to print the output to the console. from line 4to line 10
There was a problem hiding this comment.
Since it's consistent I was wondering if it was intentional, and kept as-is, but I can remove. Please chime in if this is not desired.
There was a problem hiding this comment.
It appears to be perplexing!! A couple of thoughts.
I would not print to the console since they are assigned to a variable, and if we need to look at the variable, and variables must be clearly defined with the intended meaning attached.
Can a rename the blob and text files because they contain the same data for blob3/4 and alsa3/4?
There was a problem hiding this comment.
Not sure I'm following but the ipc4 blob contains a different header, so the files are not copies.
There was a problem hiding this comment.
blob3_fn = "../../ctl/ipc3/dcblock_coef.blob";% Binary file blob
blob4_fn = "../../ctl/ipc4/dcblock_coef.blob";% Binary file blob
alsa3_fn = "../../ctl/ipc3/dcblock_coef.txt";% CSV file in ALSA format
alsa4_fn = "../../ctl/ipc4/dcblock_coef.txt";% CSV file in ALSA format
I mean, aren't dcblock_coef.blob and dcblock_coef.txt the same file?
There was a problem hiding this comment.
It's same data but different format. The binary format is for UCM, sof-ctl can use both binary and ascii decimal. I like myself the ascii decimal to quickly visually check the numbers data.
There was a problem hiding this comment.
Thanks for the explanation!
singalsu
force-pushed
the
dcblock_update_setup_tool
branch
from
2e26222 to
8a649b8
Compare
|
@singalsu This one is ready to go, but we need a clean pass of required CI. |
|
SOFCI TEST |
This patch adds generate of blob for tplg2 and ipc4 in formats .conf, text, and binary formats. Signed-off-by: Seppo Ingalsuo <[email protected]>
The abs() function need to be added to plot the correct magnitude response. Matlab warned in this case about ignoring imaginary part. Signed-off-by: Seppo Ingalsuo <[email protected]>
The script can be run in both Matlab and Octave with these changes. Signed-off-by: Seppo Ingalsuo <[email protected]>
singalsu
force-pushed
the
dcblock_update_setup_tool
branch
from
8a649b8 to
522048b
Compare
|
New force push for rebase, no changes to patch. |
No description provided.