feat: update Fairhold formula with new linear one #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DafyddLlyr
requested changes
Nov 22, 2024
app/models/Fairhold.ts
Outdated
| math.cos((2 * math.pi * this.affordability) / this.length) + | ||
| this.position; | ||
|
|
||
| const discountLand = math.max(-1.1 * this.affordability + 0.7, 0.15) |
There was a problem hiding this comment.
I think it would still be worth making these magic numbers constants, just for documentation and readability.
I agree if they're not variables, we don't need to pass them into the class or have them as properties.
There was a problem hiding this comment.
Makes sense, forgot about that whole readability thing! New commit should take care of this.
DafyddLlyr
approved these changes
Nov 22, 2024
| @@ -16,7 +21,7 @@ export class Fairhold { | |||
| } | |||
|
|
|||
| private calculateFairholdDiscount() { | |||
| const discountLand = math.max(-1.1 * this.affordability + 0.7, 0.15) | |||
| const discountLand = math.max(MULTIPLIER * this.affordability + OFFSET, PLATEAU) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why?