Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Fairhold formula with new linear one #145

Merged
merged 3 commits into from
Nov 22, 2024
Merged

feat: update Fairhold formula with new linear one #145

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf2eead
feat: update cosine formula with new linear one
zz-hh-aa Nov 22, 2024
b64cefd
chore: update tests following new fh formula
zz-hh-aa Nov 22, 2024
1de54cd
chore: magic numbers into constants
zz-hh-aa Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/models/Fairhold.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import * as math from "mathjs";

// Fairhold formula constants
const MULTIPLIER = -1.1
const OFFSET = 0.7
const PLATEAU = 0.15

type ConstructorParams = Pick<Fairhold, "affordability" | "landPriceOrRent">;

export class Fairhold {
Expand All @@ -16,7 +21,7 @@ export class Fairhold {
}

private calculateFairholdDiscount() {
const discountLand = math.max(-1.1 * this.affordability + 0.7, 0.15)
const discountLand = math.max(MULTIPLIER * this.affordability + OFFSET, PLATEAU)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer!

return discountLand;
}

Expand Down
Loading