DON-998: set PI just before processing the payment instead of at the

src/Application/Commands/TakeRegularGivingDonations.php

@@ -82,6 +82,7 @@
         $now = $this->container->get(\DateTimeImmutable::class);
 
         $this->createNewDonationsAccordingToRegularGivingMandates($now, $io);
+        $this->setPaymentIntentWhenReachedPaymentDate($now, $io);
         $this->confirmPreCreatedDonationsThatHaveReachedPaymentDate($now, $io);
 
         return 0;
@@ -101,6 +102,19 @@
         }
     }
 
+    private function setPaymentIntentWhenReachedPaymentDate(
+        \DateTimeImmutable $now,
+        SymfonyStyle $io
+    ): void {
+        $donations = $this->donationRepository->findDonationsToSetPaymentIntent($now, limit:20);
+        $io->block(count($donations) . " donations are due to have Payment Intent set at this time");
+
+        foreach ($donations as $donation) {
+            $this->donationService->createPaymentIntent($donation);
+            $io->writeln("setting payment intent on donation #{$donation->getId()}");
+        }
+    }
+
     private function confirmPreCreatedDonationsThatHaveReachedPaymentDate(
         \DateTimeImmutable $now,
         SymfonyStyle $io

src/Domain/DoctrineDonationRepository.php

@@ -741,6 +741,33 @@
         return $result;
     }
 
+    /**
+     * We only set Payment Intent on the day of the payment due to stripe limitations, see
+     */
+    public function findDonationsToSetPaymentIntent(\DateTimeImmutable $atDateTime, int $limit): array
+    {
+        $preAuthorized = DonationStatus::PreAuthorized->value;
+        $active = MandateStatus::Active->value;
+        $currentDateTime = new \DateTimeImmutable('now');
+        $dayOfMonthToday = $currentDateTime->format('d');
+
+        $query = $this->getEntityManager()->createQuery(<<<DQL
+            SELECT donation from Matchbot\Domain\Donation donation JOIN donation.mandate mandate
+            WHERE donation.donationStatus = '$preAuthorized'
+            AND mandate.status = '$active'
+            AND mandate.dayOfMonth = '$dayOfMonthToday'
+            AND donation.preAuthorizationDate <= :now
+        DQL
+        );
+
+        $query->setParameter('now', $atDateTime);
+        $query->setMaxResults($limit);
+
+        /** @var list<Donation> $result */
+        $result = $query->getResult();
+        return $result;
+    }
+
     public function findPreAuthorizedDonationsReadyToConfirm(\DateTimeImmutable $atDateTime, int $limit): array
     {
         $preAuthorized = DonationStatus::PreAuthorized->value;

src/Domain/DonationRepository.php

@@ -150,6 +150,11 @@ public function pushSalesforcePending(\DateTimeImmutable $now, MessageBusInterfa
      */
     public function findAllCompleteForCustomer(StripeCustomerId $stripeCustomerId): array;
 
+    /**
+     * @return list<Donation>
+     */
+    public function findDonationsToSetPaymentIntent(\DateTimeImmutable $atDateTime, int $limit): array;
+
     /**
      * @return list<Donation>
      */

src/Domain/RegularGivingService.php

@@ -191,7 +191,6 @@ public function makeNextDonationForMandate(RegularGivingMandate $mandate): ?Dona
             return null;
         }
 
-        $this->donationService->createPaymentIntent($donation);
         $mandate->setDonationsCreatedUpTo($preAuthorizationDate);
 
         return $donation;

tests/Domain/InMemoryDonationRepository.php

@@ -187,6 +187,11 @@ public function totalMatchFundsReleased(): string
         throw new \Exception("Method not implemented in test double");
     }
 
+    #[\Override] public function findDonationsToSetPaymentIntent(\DateTimeImmutable $atDateTime, int $limit): array
+    {
+        throw new \Exception("Method not implemented in test double");
+    }
+
     #[\Override] public function maxSequenceNumberForMandate(int $mandateId): ?DonationSequenceNumber
     {
         throw new \Exception("Method not implemented in test double");