DON-998: set PI just before processing the payment instead of at the #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
time of creating the donation DON-998 - set exception class
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1151 +/- ##
===========================================
- Coverage 75.31% 74.99% -0.33%
===========================================
Files 124 124
Lines 5465 5487 +22
===========================================
- Hits 4116 4115 -1
- Misses 1349 1372 +23 ☔ View full report in Codecov by Sentry. |
NoelLH
reviewed
Dec 27, 2024
| /** | ||
| * We only set Payment Intent on the day of the payment due to stripe limitations, see | ||
| */ | ||
| public function findDonationsToSetPaymentIntent(\DateTimeImmutable $atDateTime, int $limit): array |
There was a problem hiding this comment.
This seems to have no test coverage – would be a good fit for an integration test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time of creating the donation