Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringup Conv2d and Maxpool #13

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Bringup Conv2d and Maxpool #13

merged 1 commit into from
Oct 7, 2024

Conversation

LPanosTT
Copy link
Contributor

@LPanosTT LPanosTT commented Sep 27, 2024

Added unit tests for conv2d. Uplifted MLIR.

MLIR PR: tenstorrent/tt-mlir#836

The test cases commented out with the note: "Requires block sharding" will be resolved when the following PR is merged, or something that solves the same problem is merged: tenstorrent/tt-mlir#818

@LPanosTT LPanosTT requested review from AleksKnezevic, uazizTT and mmanzoorTT and removed request for AleksKnezevic September 27, 2024 13:58
tests/TTIR/test_conv2d.py Outdated Show resolved Hide resolved
third_party/CMakeLists.txt Outdated Show resolved Hide resolved
third_party/CMakeLists.txt Show resolved Hide resolved
@LPanosTT LPanosTT force-pushed the lpanos/conv_bringup branch 2 times, most recently from 8c17b74 to 5fe271b Compare October 1, 2024 01:07
@LPanosTT LPanosTT changed the title Bringup Conv2d Bringup Conv2d and Maxpool Oct 2, 2024
@LPanosTT LPanosTT force-pushed the lpanos/conv_bringup branch from 5fe271b to f67841b Compare October 2, 2024 20:31
src/common/module_builder.cc Outdated Show resolved Hide resolved
third_party/CMakeLists.txt Outdated Show resolved Hide resolved
@mmanzoorTT mmanzoorTT self-requested a review October 3, 2024 12:08
@LPanosTT LPanosTT force-pushed the lpanos/conv_bringup branch 2 times, most recently from 1a6bc50 to 149afaf Compare October 3, 2024 12:39
@LPanosTT LPanosTT force-pushed the lpanos/conv_bringup branch 3 times, most recently from 6c7bb13 to 50fd849 Compare October 3, 2024 15:51
…+ stablehlo --> TTIR for conv2d, maxpool2d, and reshape

Skip xfailing tests because runtime failures causing segfault on device
closuer
@LPanosTT LPanosTT force-pushed the lpanos/conv_bringup branch from 50fd849 to e190dd2 Compare October 7, 2024 13:41
@LPanosTT LPanosTT merged commit 5bb8106 into main Oct 7, 2024
3 checks passed
@LPanosTT LPanosTT deleted the lpanos/conv_bringup branch October 7, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants