[FX-1459] Move EditText methods to EditTextElement interface
#266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 13, 2024
devinmorgan
changed the title
devinmorgan
changed the title
EditTextElement interface
devinmorgan
requested review from
owenkim,
ForageRob,
dleis612,
djoksimo and
evanfreeze
as code owners
djoksimo
approved these changes
Jun 14, 2024
devinmorgan
force-pushed
the
devin/fx-1463-update-resvaluesattrsxml-so-that-all-attrs-declare-their
branch
from
2a75dc1 to
fcc0ce0
Compare
devinmorgan
force-pushed
the
devin/fx-1459-sync-edittextelement-and-forageelementt-interfaces-with-poss
branch
2 times, most recently
from
2dec633 to
d197e36
Compare
devinmorgan
force-pushed
the
devin/fx-1463-update-resvaluesattrsxml-so-that-all-attrs-declare-their
branch
from
f42e823 to
54bb224
Compare
devinmorgan
changed the base branch from
devin/fx-1463-update-resvaluesattrsxml-so-that-all-attrs-declare-their
to
main
Many of the methods originally organized under the ForageElement interface should actually live under the EditTextElement interface as not all ForageElements will specifically care to implement them (e.g. the UI-based ForagePinPad, does not care about hints, box stroke, and also has no concept of "focussed" Signed-off-by: Devin Morgan <[email protected]>
devinmorgan
force-pushed
the
devin/fx-1459-sync-edittextelement-and-forageelementt-interfaces-with-poss
branch
from
d197e36 to
9fc0eff
Compare
Merge activity
|
devinmorgan
deleted the
devin/fx-1459-sync-edittextelement-and-forageelementt-interfaces-with-poss
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Move EditText-specific methods out of
ForageElmentinterface and intoEditTextElementinterface.Why
Leaving these methods on the
ForageElementwould force the Pos SDK's non-EditText-based UI components to implement these methods, which makes no sense. Methods that make sense for EditText UI components should live on the EditText-specific interface and not on the base ForageElement interface that even non-EditText UI components implement.Test Plan
Demo
N/A as this is just implementation
How
Can be merged after #265 is merged