Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-1463] Add types to ForagePINEditText custom styles #265

Conversation

devinmorgan
Copy link
Contributor

@devinmorgan devinmorgan commented Jun 13, 2024

What

Adds missing types to <attr />s on the ForagePINEditText's `.

Why

Overcommunicate to SDK users the intended type of these <attr />.

Test Plan

  • ❌ I've added unit tests for this change.
  • ❌ Manual testing is unnecessary since these changes do not affect runtime; they are largely just for documentation.

Demo

N/A These changes don't have an affect on runtime so nothing to demo

How

Can be rolled out immediately

@devinmorgan devinmorgan marked this pull request as ready for review June 13, 2024 18:52
@devinmorgan devinmorgan changed the title Add missing ForagePINEditText declare-styleable types [FX-1463] Add types to ForagePINEditText custom styles Jun 13, 2024
Copy link
Contributor

@djoksimo djoksimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU! Left a comment about spacing

forage-android/src/main/res/values/attrs.xml Outdated Show resolved Hide resolved
@devinmorgan devinmorgan force-pushed the devin/fx-1462-use-shared-okhttpclient-within-okhttpclientbuilder branch from bd3fef4 to dcbcbdf Compare June 17, 2024 12:02
@devinmorgan devinmorgan force-pushed the devin/fx-1463-update-resvaluesattrsxml-so-that-all-attrs-declare-their branch from 2a75dc1 to fcc0ce0 Compare June 17, 2024 12:02
@devinmorgan devinmorgan force-pushed the devin/fx-1462-use-shared-okhttpclient-within-okhttpclientbuilder branch from dcbcbdf to 7311b7a Compare June 17, 2024 15:24
@devinmorgan devinmorgan changed the base branch from devin/fx-1462-use-shared-okhttpclient-within-okhttpclientbuilder to main June 17, 2024 15:27
@devinmorgan devinmorgan force-pushed the devin/fx-1463-update-resvaluesattrsxml-so-that-all-attrs-declare-their branch from f42e823 to 54bb224 Compare June 17, 2024 15:31
Copy link
Contributor Author

devinmorgan commented Jun 17, 2024

Merge activity

  • Jun 17, 11:32 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 17, 11:33 AM EDT: @devinmorgan merged this pull request with Graphite.

@devinmorgan devinmorgan merged commit 6960592 into main Jun 17, 2024
5 checks passed
@devinmorgan devinmorgan deleted the devin/fx-1463-update-resvaluesattrsxml-so-that-all-attrs-declare-their branch July 1, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants