-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX-1463] Add types to ForagePINEditText
custom styles
#265
Merged
devinmorgan
merged 2 commits into
main
from
devin/fx-1463-update-resvaluesattrsxml-so-that-all-attrs-declare-their
Jun 17, 2024
Merged
[FX-1463] Add types to ForagePINEditText
custom styles
#265
devinmorgan
merged 2 commits into
main
from
devin/fx-1463-update-resvaluesattrsxml-so-that-all-attrs-declare-their
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 13, 2024
This was referenced Jun 13, 2024
devinmorgan
requested review from
owenkim,
ForageRob,
dleis612,
djoksimo and
evanfreeze
as code owners
June 13, 2024 18:52
devinmorgan
changed the title
Add missing ForagePINEditText declare-styleable types
[FX-1463] Add types to Jun 13, 2024
ForagePINEditText
custom styles
djoksimo
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANK YOU! Left a comment about spacing
devinmorgan
force-pushed
the
devin/fx-1462-use-shared-okhttpclient-within-okhttpclientbuilder
branch
from
June 17, 2024 12:02
bd3fef4
to
dcbcbdf
Compare
devinmorgan
force-pushed
the
devin/fx-1463-update-resvaluesattrsxml-so-that-all-attrs-declare-their
branch
from
June 17, 2024 12:02
2a75dc1
to
fcc0ce0
Compare
devinmorgan
force-pushed
the
devin/fx-1462-use-shared-okhttpclient-within-okhttpclientbuilder
branch
from
June 17, 2024 15:24
dcbcbdf
to
7311b7a
Compare
devinmorgan
changed the base branch from
devin/fx-1462-use-shared-okhttpclient-within-okhttpclientbuilder
to
main
June 17, 2024 15:27
Signed-off-by: Devin Morgan <[email protected]>
devinmorgan
force-pushed
the
devin/fx-1463-update-resvaluesattrsxml-so-that-all-attrs-declare-their
branch
from
June 17, 2024 15:31
f42e823
to
54bb224
Compare
Merge activity
|
devinmorgan
deleted the
devin/fx-1463-update-resvaluesattrsxml-so-that-all-attrs-declare-their
branch
July 1, 2024 12:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds missing types to
<attr />
s on theForagePINEditText
's `.Why
Overcommunicate to SDK users the intended type of these
<attr />
.Test Plan
Demo
N/A These changes don't have an affect on runtime so nothing to demo
How
Can be rolled out immediately