Vision alignment to SS #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barakshelef
requested changes
Mar 3, 2023
barakshelef
force-pushed
the
substation-vision
branch
2 times, most recently
from
d36a982 to
4183842
Compare
DarkMetalMouse
changed the base branch from
isr-1-changes
to
isr-1-changes-cleanup
frc3316
force-pushed
the
substation-vision
branch
from
4183842 to
b1162a3
Compare
barakshelef
reviewed
Mar 11, 2023
| double[] poseComponents = limeLightTable.getEntry(entryName).getDoubleArray(new double[6]); | ||
| if (poseComponents.length == 0) | ||
| return null; | ||
| double latency = limeLightTable.getEntry("tl").getDouble(0) + limeLightTable.getEntry("cl").getDouble(0); |
There was a problem hiding this comment.
According to @jizelda this is returned in the 7th value of botpose in the latest version of the limelight firmware.
barakshelef
approved these changes
Mar 11, 2023
barakshelef
force-pushed
the
substation-vision
branch
from
ebd1784 to
ac3c67e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.