Updated FRC page with 2020 game info and videos #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linked in new videos and game manual, added logo to assets
darrenkwee2
changed the title
darrenkwee2
changed the title
darrenkwee2
changed the title
TJScalzo
changed the title
|
You need to put the issue number in the comment/body of the pull request for it to link to the issue properly. It's kind of confusing since you can put it in the title of commits, but that's just how it is for pull requests. |
TJScalzo
requested changes
Feb 7, 2020
There was a problem hiding this comment.
The logo has invisible padding built into it. This means the padding that is applied to images by the site's CSS is adding onto the built-in padding. This leads to extra whitespace around that image that doesn't look right. Be sure to crop the invisible padding out of images before adding them to the site.
5 tasks
in order to remove the weird spacing around the image on the FRC page (For #139)
|
Thanks Tim! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linked in new videos and game manual, added logo to assets
(For #139)