Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): create spacing utilities from tokens #3557

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

alizedebray
Copy link
Contributor

I recommend reviewing this pull request one commit at a time:

  • The first commit (feat(styles): create spacing utilities from tokens) is the actual implementation of the new margin, padding, and gap utilities from the token map.

  • The second commit (chore: apply new spacing utilities) is purely a refactor, where the old spacing utilities are replaced with the newly created ones.

@alizedebray alizedebray requested a review from a team as a code owner September 18, 2024 11:26
@alizedebray alizedebray linked an issue Sep 18, 2024 that may be closed by this pull request
1 task
Copy link

changeset-bot bot commented Sep 18, 2024

🦋 Changeset detected

Latest commit: 28a6eb2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@swisspost/design-system-styles Major
@swisspost/design-system-documentation Minor
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components Major
@swisspost/design-system-demo Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header Major
@swisspost/design-system-styles-primeng Major
@swisspost/design-system-components-react Major
@swisspost/design-system-components-angular Major
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-tokens Major
@swisspost/design-system-icons Major
@swisspost/design-system-migrations Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Sep 18, 2024

Related Previews

@alizedebray alizedebray force-pushed the 3434-component-spacing-utilities branch 4 times, most recently from 100b13a to 53339ed Compare September 23, 2024 11:30
@alizedebray alizedebray force-pushed the 3434-component-spacing-utilities branch from f739103 to 2ce5c34 Compare September 25, 2024 15:18
@alizedebray alizedebray force-pushed the 3434-component-spacing-utilities branch from 2ce5c34 to 0206600 Compare September 25, 2024 15:28
Copy link
Member

@gfellerph gfellerph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added #3639 to document the breaking change.

Copy link

sonarqubecloud bot commented Oct 3, 2024

@alizedebray alizedebray merged commit 99336ec into main Oct 4, 2024
12 checks passed
@alizedebray alizedebray deleted the 3434-component-spacing-utilities branch October 4, 2024 07:03
gfellerph pushed a commit that referenced this pull request Oct 8, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`main` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `main`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @swisspost/[email protected]

### Major Changes

- Made the heading-level property required for the accordion and removed
it from the accordion-item docs. (by
[@schaertim](https://github.com/schaertim) with
[#3383](#3383))

### Patch Changes

- Fixed a bug in nested accordions where closing a child item
unintentionally closed all parent accordion elements. (by
[@schaertim](https://github.com/schaertim) with
[#3427](#3427))

- Fixed an issue related to conflicting pointer and focus events hiding
the tooltip unexpectedly in some situations. The tooltip now behaves as
expected in this situation. (by
[@alionazherdetska](https://github.com/alionazherdetska) with
[#3592](#3592))

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Major Changes

- Removed the following placeholders: `%list-adjustment`,
`%module-container`, `%default-module-spacer`, `%text-container`. (by
[@leagrdv](https://github.com/leagrdv) with
[#3623](#3623))

- Updated the margin, padding, and gap utility classes to use the pixel
values (1, 2, ... , 112) instead of size names (hair, line, ...,
bigger-giant). (by [@alizedebray](https://github.com/alizedebray) with
[#3557](#3557))

### Minor Changes

- Added Text Highlighted component. (by
[@bashirkarimi](https://github.com/bashirkarimi) with
[#3586](#3586))

- Added lead text component for introductory paragraphs. (by
[@bashirkarimi](https://github.com/bashirkarimi) with
[#3575](#3575))

### Patch Changes

- styles: Added reset styles (by
[@bashirkarimi](https://github.com/bashirkarimi) with
[#3545](#3545))

- Removed global styles (by
[@bashirkarimi](https://github.com/bashirkarimi) with
[#3554](#3554))

- Updated the style of headings (h1-h6). (by
[@bashirkarimi](https://github.com/bashirkarimi) with
[#3534](#3534))

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]



## @swisspost/[email protected]



## @swisspost/[email protected]

### Major Changes

- Made the heading-level property required for the accordion and removed
it from the accordion-item docs. (by
[@schaertim](https://github.com/schaertim) with
[#3383](#3383))

### Minor Changes

- Added a toolbar for switching the theme, channel, and mode of all
stories. (by [@alizedebray](https://github.com/alizedebray) with
[#3528](#3528))

- Added documentation outlining the mission statement of the Design
System. (by [@alionazherdetska](https://github.com/alionazherdetska)
with [#3568](#3568))

- Added Text Highlighted component. (by
[@bashirkarimi](https://github.com/bashirkarimi) with
[#3586](#3586))

- Updated the margin, padding, and gap utility classes to use the pixel
values (1, 2, ... , 112) instead of size names (hair, line, ...,
bigger-giant). (by [@alizedebray](https://github.com/alizedebray) with
[#3557](#3557))

- Added documentation for design principles. (by
[@alionazherdetska](https://github.com/alionazherdetska) with
[#3565](#3565))

- Added lead text component for introductory paragraphs. (by
[@bashirkarimi](https://github.com/bashirkarimi) with
[#3575](#3575))

### Patch Changes

- Updated the style of headings (h1-h6). (by
[@bashirkarimi](https://github.com/bashirkarimi) with
[#3534](#3534))

- Fixed typos in the Sass and HTML href paths. (by
[@schaertim](https://github.com/schaertim) with
[#3466](#3466))

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[component]: Spacing utilities
3 participants