Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[helpers]: Palettes #3432

Closed
3 tasks done
alizedebray opened this issue Aug 20, 2024 · 7 comments · Fixed by #3850
Closed
3 tasks done

[helpers]: Palettes #3432

alizedebray opened this issue Aug 20, 2024 · 7 comments · Fixed by #3850
Assignees
@alizedebray
Labels
📦 styles Related to the @swisspost/design-system-styles package
Milestone
PPNL Components

Comments

@alizedebray
Copy link
Contributor

alizedebray commented Aug 20, 2024 •
edited
Loading

Description

Classes to allow user to set a color set on any HTML section.

Design

There is no design for the helpers.

Token proposal

  • post.palette.brand.fg
  • post.palette.brand.bg
  • post.palette.brand.bg-scheme
  • post.palette.accent.fg
  • post.palette.accent.bg
  • post.palette.accent.bg-scheme
  • post.palette.default.fg
  • post.palette.default.bg
  • post.palette.default.bg-scheme
  • post.palette.alternate.fg
  • post.palette.alternate.bg
  • post.palette.alternate.bg-scheme

Tasks

💻 Tasks
Preview Give feedback
@alizedebray alizedebray added the 📦 components Related to the @swisspost/design-system-components package label Aug 20, 2024
@alizedebray alizedebray added this to the Design v2 milestone Aug 20, 2024
@gfellerph gfellerph added needs: 💬 pattern discussion This issue will be discussed in the next Pattern Discussion meeting. needs: discussion There is at least one topic in the pattern descussion meeting about the issue labels Sep 6, 2024
@gfellerph
Copy link
Member

Already in Design (called Surface), tokens are easy to add.

@gfellerph gfellerph added 📦 styles Related to the @swisspost/design-system-styles package and removed needs: discussion There is at least one topic in the pattern descussion meeting about the issue needs: 💬 pattern discussion This issue will be discussed in the next Pattern Discussion meeting. 📦 components Related to the @swisspost/design-system-components package labels Sep 10, 2024
@oliverschuerch
Copy link
Contributor

Depends on #3557

@gfellerph gfellerph moved this from 👀 Triage to 🔮 Ready for tokenisation in Design System Production Board Sep 25, 2024
@gfellerph gfellerph modified the milestones: Design v2, Cargo Components Oct 1, 2024
@gfellerph
Copy link
Member

Does a specific surface also hold information if it's on a light or dark background? I think this needs some more discussion with Design and a better strategy on how we want to implement it.

@gfellerph gfellerph added needs: discussion There is at least one topic in the pattern descussion meeting about the issue needs: 💬 pattern discussion This issue will be discussed in the next Pattern Discussion meeting. labels Oct 14, 2024
@alizedebray alizedebray removed needs: discussion There is at least one topic in the pattern descussion meeting about the issue needs: 💬 pattern discussion This issue will be discussed in the next Pattern Discussion meeting. labels Oct 29, 2024
@alizedebray alizedebray changed the title [component]: Background utilities [helpers]: Palettes Oct 29, 2024
@alizedebray alizedebray linked a pull request Oct 29, 2024 that will close this issue
feat(styles): add palettes #3850
Merged
@alizedebray alizedebray moved this from 🕹️ Coding in progress to 🤬 Dev in review in Design System Production Board Oct 29, 2024
@alizedebray alizedebray moved this from 🤬 Dev in review to 🔮 Ready for tokenisation in Design System Production Board Nov 5, 2024
@alizedebray alizedebray assigned Vandapanda and unassigned alizedebray Nov 5, 2024
@Vandapanda Vandapanda removed their assignment Nov 5, 2024
@alizedebray alizedebray self-assigned this Nov 5, 2024
@alizedebray
Copy link
Contributor Author

alizedebray commented Nov 5, 2024 •
edited
Loading

@Vandapanda can you please rename "palette" to "palettes" to align with other sets and also add tokens for all theme/schemes (post-light, post-dark, cargo-light, cargo-dark)? Even if the colors are not correct for now, otherwise I get missing token errors. Thanks!

PS: the token names also still contain "helper" which is probably not what we want: Image

@alizedebray alizedebray moved this from 💻 Ready for development to 🔮 Ready for tokenisation in Design System Production Board Nov 5, 2024
@alizedebray alizedebray moved this from 🔮 Ready for tokenisation to 🤬 Dev in review in Design System Production Board Nov 5, 2024
@alizedebray alizedebray moved this from 🤬 Dev in review to 🔮 Ready for tokenisation in Design System Production Board Nov 5, 2024
@Vandapanda
Copy link
Contributor

@alizedebray Changed the namings accordingly and will get pushed in a few hours. For the 2nd request I'm kind of missing some context. As it is right now the colors automatically change based on what canvas is used as they are rooted through scheme and theme. Do you need them hardcoded?

@alizedebray
Copy link
Contributor Author

@Vandapanda
Currently we have this tokens:
Image

And we would need to have this:
Image

@alizedebray
Copy link
Contributor Author

alizedebray commented Nov 11, 2024 •
edited
Loading

Latest state, some tokens are still missing for Cargo:
Image

@Vandapanda Vandapanda removed their assignment Nov 12, 2024
@github-project-automation github-project-automation bot moved this from 🤬 Dev in review to 🚀 Done in Design System Production Board Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alizedebray alizedebray

Labels
📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Status: 🚀 Done
Milestone
PPNL Components
Development

Successfully merging a pull request may close this issue.

feat(styles): add palettes swisspost/design-system
4 participants
@gfellerph @oliverschuerch @alizedebray @Vandapanda