Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Send" Button in the Footer Section Should Be Centered #464 #558

Closed
wants to merge 6 commits into from

Conversation

arpit74170
Copy link

@arpit74170 arpit74170 commented Oct 18, 2024

I have done the fixing of the send button n the center of the form as request by the user

Pull Request Format

PR Title

Issue #464 : The "Send" Button in the Footer Section Should Be Centered #464 solved

Type of PR

  • Add X in the box to specify the improvement type.
  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): ___________

Description

This pull request aims to [briefly describe what the pull request does, e.g., "add a new feature," "fix a bug," "improve documentation," etc.].

Screenshots / Videos (if applicable)

Before:

  • [Describe the state before the changes, e.g., "The section headings in the footer were misaligned, leading to an inconsistent and cluttered appearance."]

After:

  • [Describe the state after the changes, e.g., "The section headings in the footer are now properly aligned, providing a clean and professional look."]

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

[Provide any additional context about the changes, such as specific challenges you faced or decisions you made. This can help reviewers understand the rationale behind your changes.]

Thank you for reviewing my pull request!

…#464

I have done the fixing of the send button n the center of the form as request by the user
Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 4:08pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @arpit74170! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit c126cb7
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/671a7102d47f4a000864602b
😎 Deploy Preview https://deploy-preview-558--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@arpit74170
Copy link
Author

Look on it...if it is ok then merge it...otherwise tells me what is not okk

index.html Outdated
@@ -675,7 +675,7 @@ <h2>Feedback Form</h2>
<input type="email" name="email" class="text-input contact-input"
placeholder="Your email address...">
<textarea name="message" class="text-input contact-input" placeholder="Your message..."></textarea>
<button type="submit" class="btn btn-big contact-btn">
<button style="position: relative ; left: -50px" type="submit" class="btn btn-big contact-btn ">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add styles directly in the HTML. We have a CSS file for that. Mixing them makes the project harder to maintain.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay i will fix it today only....dont assign to any one else

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@arpit74170
Copy link
Author

Okay i will fix it.. today only...dont assign to any one else

…#464

I have fix the issue as ask by you in style css file for a better code
@arpit74170
Copy link
Author

Check it and give me response

I have done this before but the pull request was cancel so i am doing this again , the position and left is done by me only in css file as said by do
@arpit74170
Copy link
Author

Sir pls have a look on it

@arpit74170 arpit74170 closed this Oct 24, 2024
@arpit74170
Copy link
Author

I am adding new pull reuest

arpit74170 added a commit to arpit74170/Collect-your-GamingTools that referenced this pull request Oct 24, 2024
…#464 swaraj-das#558

I am re doing it , all the changes previously is done my me only
position:relative;
left:-60px; is done by me but to reopen this ihave changes the line in this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants