Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Send" Button in the Footer Section Should Be Centered #464 #558 #674

Closed
wants to merge 7 commits into from

Conversation

arpit74170
Copy link

Pull Request Format

PR Title

Issue #558 ISSUE NAME solved

Type of PR

  • Add X in the box to specify the improvement type.
  • Bug fix
  • [ X] Feature enhancement
  • [X ] Documentation update
  • Other (specify): ___________

Description

This pull request aims to [briefly describe what the pull request does, e.g., "add a new feature," "fix a bug," "improve documentation," etc.].

Screenshots / Videos (if applicable)

Before:

  • [Describe the state before the changes, e.g., "The section headings in the footer were misaligned, leading to an inconsistent and cluttered appearance."]

After:

  • [Describe the state after the changes, e.g., "The section headings in the footer are now properly aligned, providing a clean and professional look."]

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • [ X] I have tested the changes thoroughly before submitting this pull request.
  • [X ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [X ] I have commented my code, particularly in hard-to-understand areas.

Additional Context

Sir i have done the changes to fix the button in center as ask by you that the style should be in css file , but i have merged it into main , so i am re doing it by changing the line , have a look on it

Thank you for reviewing my pull request!

…#464

I have done the fixing of the send button n the center of the form as request by the user
…#464

I have done the changes as ask by you for centering the buttton
…#464

I have fix the issue as ask by you in style css file for a better code
I have done this before but the pull request was cancel so i am doing this again , the position and left is done by me only in css file as said by do
…#464 swaraj-das#558

I am re doing it , all the changes previously is done my me only
position:relative;
left:-60px; is done by me but to reopen this ihave changes the line in this
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 4:19pm

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit efc360f
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/671a73a5ded5b9000889a8fd
😎 Deploy Preview https://deploy-preview-674--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @arpit74170! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

3 similar comments
Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@aslams2020
Copy link

@swaraj-das Can you look into this? It's still not merged yet #464
It dont have any conflicts. Please take a look into it.

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

1 similar comment
Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@swaraj-das
Copy link
Owner

The footer was updated before your pull request

@swaraj-das swaraj-das closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants