Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successfully youtube icon got responsive with hover and removed twitter duplicates #549

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

SumithThota
Copy link
Contributor

Successfully youtube icon got responsive with hover and removed twitter duplicates

Resolved Issue No: #548

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): ___________

Description

This pull request aims to fix a bug that is previously this project had un responsive youtube icon on home page and had two (X & twitter icons in about-us page)
Those bugs are now succesfully fixed via this PR

Screenshots / Videos (if applicable)

Before:-

Unresponsive Youtube Icon

missing.hover.effect.mp4

Duplicates of twitter and X

Screenshot 2024-10-18 115806

After:-

##Responsive Youtube Icon
https://github.com/user-attachments/assets/8a5caffc-bc22-4eb2-a81b-4d462a630c23

After removing twitter bird

Screenshot 2024-10-18 152214

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

Add gssoc-ext, hacktoberfest-accepted labels to this PR
Thank you for reviewing my pull request!

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 9:59am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @SumithThota! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 6d00235
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/671231749919ca00080e47b2
😎 Deploy Preview https://deploy-preview-549--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@swaraj-das swaraj-das merged commit bbc6499 into swaraj-das:main Oct 19, 2024
6 checks passed
Copy link

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants