Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETHEREUM-CONTRACTS] PureSuperToken downgrade logic fixed #1705

Closed
wants to merge 2 commits into from
Closed

[ETHEREUM-CONTRACTS] PureSuperToken downgrade logic fixed #1705

wants to merge 2 commits into from

Conversation

0xdavinchee
Copy link
Contributor

  • We no longer revert when downgrading pure super tokens

@0xdavinchee 0xdavinchee added Tag: TechDebt Technical debt that needs to be addressed Severity: Low Size: S Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps labels Sep 28, 2023
@0xdavinchee 0xdavinchee self-assigned this Sep 28, 2023
@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited by hellwolf
Loading

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@hellwolf hellwolf linked an issue Sep 28, 2023 that may be closed by this pull request
[ETHEREUM-CONTRACTS] ERC-777 burn won't work for pure SuperTokens #1258
Closed
hellwolf
hellwolf reviewed Sep 28, 2023
View reviewed changes
Copy link
Contributor

@hellwolf hellwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@d10r please have a look too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellwolf hellwolf hellwolf left review comments

Assignees

@0xdavinchee 0xdavinchee

Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Severity: Low Size: S Tag: TechDebt Technical debt that needs to be addressed Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ETHEREUM-CONTRACTS] ERC-777 burn won't work for pure SuperTokens
2 participants
@0xdavinchee @hellwolf