Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETHEREUM-CONTRACTS] ERC-777 burn won't work for pure SuperTokens #1258

Closed
d10r opened this issue Jan 19, 2023 · 3 comments
Closed

[ETHEREUM-CONTRACTS] ERC-777 burn won't work for pure SuperTokens #1258

d10r opened this issue Jan 19, 2023 · 3 comments
Assignees
@0xdavinchee
Labels
Severity: Low Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps Type: Bug Something isn't working

Comments

@d10r
Copy link
Collaborator

d10r commented Jan 19, 2023 •
edited
Loading

always invokes downgrade().
should instead just burn if underlying is zero
@d10r d10r changed the title ERC-777 burn won't work for pure SuperTokens (always invokes downgrade) [ETHEREUM-CONTRACTS] ERC-777 burn won't work for pure SuperTokens Jan 19, 2023
@hellwolf hellwolf added Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps Type: Bug Something isn't working labels Aug 23, 2023
@hellwolf
Copy link
Contributor

Is it still the case?

@hellwolf hellwolf added the Tag: Help Me Whelp! extra attention is needed here label Aug 24, 2023
@hellwolf hellwolf removed the Tag: Help Me Whelp! extra attention is needed here label Sep 28, 2023
@hellwolf
Copy link
Contributor

This is still a problem.

The expected behaviour should be that when it is a super token without underlying token, the burn function should not call downgrade().

@0xdavinchee 0xdavinchee self-assigned this Sep 28, 2023
@hellwolf hellwolf linked a pull request Sep 28, 2023 that will close this issue
[ETHEREUM-CONTRACTS] PureSuperToken downgrade logic fixed #1705
Closed
@0xdavinchee
Copy link
Contributor

closing this issue now as the opened PR illustrated that it's more of a semantic bug as discussed in slack here.

@vmichalik vmichalik mentioned this issue Dec 8, 2023
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xdavinchee 0xdavinchee

Labels
Severity: Low Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ETHEREUM-CONTRACTS] PureSuperToken downgrade logic fixed superfluid-finance/protocol-monorepo
3 participants
@hellwolf @d10r @0xdavinchee