fixing read_list_by_name looping on MAX_ADS_SUB_COMMANDS case with lo…

[SISAutomationIMA]

This pull request fixes an issue encountered when using the read_list_by_name function with structure_defs. If more than 500 tags are read and structure_defs is provided with a size matching the tags being requested, the for loop in sum_read raises an error. This happens because the tag list is sliced, but structure_defs is not.

To address this, I adjusted the for loop to ensure that the sliced chunk also includes the corresponding tags in structure_defs. This change resolves the issue.

[chrisbeardy]

thanks for this, will look at this shortly

[coveralls]

Pull Request Test Coverage Report for Build 12137829102

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.002%) to 94.953%

---

Totals
Change from base Build 11345095278:	0.002%
Covered Lines:	1731
Relevant Lines:	1823

---

💛 - Coveralls

[chrisbeardy]

nice work, thank you, how do you fancy taking a look and seeing if this affects write_list_by_name too?

[SISAutomationIMA]

nice work, thank you, how do you fancy taking a look and seeing if this affects write_list_by_name too?

Thank you for the Response ! After testing and reviewing the source code, I found that the issue only affects the read_list_by_name function. The loop in the write_list_by_name function handles the operation correctly, so no changes are needed there.

[chrisbeardy]

Awesome thank you so much!