Skip to content

Commit

Permalink
fixing read_list_by_name looping on MAX_ADS_SUB_COMMANDS case with lo…
Browse files Browse the repository at this point in the history
…ng structure_defs (#438)

Co-authored-by: Allix Souchet <[email protected]>
  • Loading branch information
SISAutomationIMA and Allix Souchet authored Dec 6, 2024
1 parent 87c0681 commit 9578a46
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions pyads/connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -598,8 +598,9 @@ def sum_read(port: int, adr: AmsAddr, data_names: List[str],
list(structure_defs.keys())) # type: ignore

for data_name, structure_def in structure_defs.items(): # type: ignore
result[data_name] = dict_from_bytes(result[data_name],
structure_def) # type: ignore
if data_name in result:
result[data_name] = dict_from_bytes(result[data_name],
structure_def)

return result

Expand Down Expand Up @@ -691,7 +692,7 @@ def write_by_name(
return adsSyncWriteByNameEx(
self._port, self._adr, data_name, value, plc_datatype, handle=handle
)

def write_list_by_name(
self,
data_names_and_values: Dict[str, Any],
Expand Down

0 comments on commit 9578a46

Please sign in to comment.