Remove incorrect textDocument/diagnostic request handler

[muxcmux]

The parameters for this request only include a textDocument, which is a TextDocumentIdentifier, an identifier? and a previousResultId?. The TextDocumentIdentifer only has a uri property, which is of type DocumentUri.

According to the LSP spec:

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_diagnostic

this request does not include the contents of the file (which is what the handler was expecting).

I have simply made the handling of this request a no-op, since diagnostics are already sent to the client in textDocument/didChange.

Note: This also fixes formatting problems related to Neovim 0.10 described in #575

[searls]

Thanks for submitting this. Since VS Code in particular feels pretty black-box with respect to what it expects (and what it will reject) from an LSP server, I'd be reticent for this to be merged before someone first tested it against https://github.com/standardrb/vscode-standard-ruby

[muxcmux]

I don't follow. This has nothing to do with vscode.

The handling of textDocument/diagnostic is not correct because the parameters do not include the document text - it's literally in the specs.

[searls]

Because I assumed (and just confirmed) this method was added because VS Code was spewing errors without it.

[muxcmux]

I see. That method is still there though, I only made it a no-op. No errors in vscode as far as I can tell (fresh install of vscode, standardrb running with my patch):

Screen.Recording.2024-01-31.at.09.38.51.mp4

... but I don't use vscode, so might not be a reliable test.

[searls]

Gonna take @muxcmux word for it here. We can always revert if we cut a release and this doesn't work. Sorry for taking months to get around to this