Merge pull request #601 from muxcmux/main

Remove incorrect textDocument/diagnostic request handler
standardrb · Apr 24, 2024 · 9917773 · 9917773
2 parents 3f86557 + af486c1
commit 9917773
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 33 deletions.
diff --git a/lib/standard/lsp/routes.rb b/lib/standard/lsp/routes.rb
@@ -51,10 +51,8 @@ def for(name)
         end
       end
 
-      handle "textDocument/diagnostic" do |request|
-        doc = request[:params][:textDocument]
-        result = diagnostic(doc[:uri], doc[:text])
-        @writer.write(result)
+      handle "textDocument/diagnostic" do |_request|
+        # no op, diagnostics are handled in textDocument/didChange
       end
 
       handle "textDocument/didChange" do |request|

diff --git a/test/standard/runners/lsp_test.rb b/test/standard/runners/lsp_test.rb
@@ -72,40 +72,13 @@ def test_diagnotic_route
       jsonrpc: "2.0",
       params: {
         textDocument: {
-          languageId: "ruby",
-          text: "def hi\n  [1, 2,\n   3  ]\nend\n",
-          uri: "file:///path/to/file.rb",
-          version: 0
+          uri: "file:///path/to/file.rb"
         }
       }
     })
 
     assert_equal "", err.string
-    assert_equal 1, msgs.count
-    assert_equal({
-      method: "textDocument/publishDiagnostics",
-      params: {
-        diagnostics: [
-          {code: "Layout/ArrayAlignment",
-           message: "Use one level of indentation for elements following the first line of a multi-line array.",
-           range: {start: {character: 3, line: 2}, end: {character: 3, line: 2}},
-           severity: 3,
-           source: "standard"},
-          {code: "Layout/ExtraSpacing",
-           message: "Unnecessary spacing detected.",
-           range: {start: {character: 4, line: 2}, end: {character: 4, line: 2}},
-           severity: 3,
-           source: "standard"},
-          {code: "Layout/SpaceInsideArrayLiteralBrackets",
-           message: "Do not use space inside array brackets.",
-           range: {start: {character: 4, line: 2}, end: {character: 5, line: 2}},
-           severity: 3,
-           source: "standard"}
-        ],
-        uri: "file:///path/to/file.rb"
-      },
-      jsonrpc: "2.0"
-    }, msgs.first)
+    assert_equal 0, msgs.count
   end
 
   def test_format