-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Upload from Tribes to Meme Server #894
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me I just added some changes for logs and code quality changes
err = json.Unmarshal(body, &memeChallenge) | ||
|
||
if err != nil { | ||
log.Printf("Reading Invoice body failed: %s", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this an invoice?
* added decode invoice test * started working on meme upload * uploaded image successfully * added meme result * Finished upload meme image * fixed prettier * updated Readme * fixed test error and enforced creation of uploads directory * removed invoice test * move meme functions to a meme file * updated README.md * fixed error messages
Describe your changes
This PR allows an image upload to the meme Server
Issue ticket number and link
Closes #880
Type of change
Checklist before requesting a review