Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Upload from Tribes to Meme Server #894

Merged
merged 12 commits into from
Nov 9, 2023
Merged

Conversation

elraphty
Copy link
Contributor

@elraphty elraphty commented Nov 7, 2023

Describe your changes

This PR allows an image upload to the meme Server

Issue ticket number and link

Closes #880

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device

@elraphty elraphty requested a review from kevkevinpal November 7, 2023 18:31
Copy link
Contributor

@kevkevinpal kevkevinpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments

handlers/organizations.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kevkevinpal kevkevinpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me I just added some changes for logs and code quality changes

handlers/meme.go Outdated Show resolved Hide resolved
handlers/meme.go Outdated Show resolved Hide resolved
err = json.Unmarshal(body, &memeChallenge)

if err != nil {
log.Printf("Reading Invoice body failed: %s", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this an invoice?

handlers/meme.go Outdated Show resolved Hide resolved
handlers/meme.go Show resolved Hide resolved
handlers/meme.go Show resolved Hide resolved
@kevkevinpal kevkevinpal merged commit 787c2f1 into master Nov 9, 2023
4 checks passed
@kevkevinpal kevkevinpal mentioned this pull request Nov 9, 2023
5 tasks
elraphty added a commit that referenced this pull request Jan 26, 2024
* added decode invoice test

* started working on meme upload

* uploaded image successfully

* added meme result

* Finished upload meme image

* fixed prettier

* updated Readme

* fixed test error and enforced creation of uploads directory

* removed invoice test

* move meme functions to a meme file

* updated README.md

* fixed error messages
@Evanfeenstra Evanfeenstra deleted the feat/meme_server branch January 26, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open up an endpoint to the meme server
2 participants