-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/create org flow #909
Conversation
@tobi-bams I just merged @elraphty change for meme upload we might want to try and use that in this PR the endpoint is |
Thanks!!!.... I will do that and push new changes!! |
@kevkevinpal and @ecurrencyhodler, done with this PR, below is the link to demo |
This looks great! But let's also keep the circle for the logos. We shouldn't display it as a square. Update that and let's do another code review b4 we merge. |
Here's the link in figma. Use dev mode for specific requirements. |
@ecurrencyhodler here is the updated PR: |
LGTM. Let's a code review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments and questions to get your input
// function addToast(title: string) { | ||
// setToasts([ | ||
// { | ||
// id: '1', | ||
// title, | ||
// color: 'danger' | ||
// } | ||
// ]); | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we delete commented code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sure I will
} | ||
} catch (error) { | ||
addErrorToast('Error occured while creating organization'); | ||
console.log('Error occured', error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets make this either a console.warn
or console.error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright....
@kevkevinpal made the changes! |
* update: updated the UI flow for add organization * update: image can be dragged and dropped, also new organization can be created * update: add organization and upload image from browser directly * fix: fixed file_uploader not returning link * update: added click on the upload button * update: styled the org list component properly * update: reverse a change made earlier
Describe your changes
Issue ticket number and link
Type of change
Please delete options that are not relevant.
Checklist before requesting a review