Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/create org flow #909

Merged
merged 10 commits into from
Nov 15, 2023
Merged

Update/create org flow #909

merged 10 commits into from
Nov 15, 2023

Conversation

tobi-bams
Copy link
Contributor

Describe your changes

Issue ticket number and link

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend
Screenshot 2023-11-09 at 02 02 18 Screenshot 2023-11-09 at 02 03 11 Screenshot 2023-11-09 at 02 04 08

@tobi-bams tobi-bams linked an issue Nov 9, 2023 that may be closed by this pull request
@kevkevinpal
Copy link
Contributor

@tobi-bams I just merged @elraphty change for meme upload we might want to try and use that in this PR

#894

the endpoint is /meme_upload

@tobi-bams
Copy link
Contributor Author

@tobi-bams I just merged @elraphty change for meme upload we might want to try and use that in this PR

#894

the endpoint is /meme_upload

Thanks!!!....

I will do that and push new changes!!

@tobi-bams
Copy link
Contributor Author

@kevkevinpal and @ecurrencyhodler, done with this PR, below is the link to demo

Demo

@ecurrencyhodler
Copy link
Contributor

This looks great! But let's also keep the circle for the logos. We shouldn't display it as a square. Update that and let's do another code review b4 we merge.

@ecurrencyhodler
Copy link
Contributor

Here's the link in figma. Use dev mode for specific requirements.

@tobi-bams
Copy link
Contributor Author

@ecurrencyhodler here is the updated PR:

update

@ecurrencyhodler
Copy link
Contributor

LGTM. Let's a code review.

Copy link
Contributor

@kevkevinpal kevkevinpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments and questions to get your input

Comment on lines 171 to 179
// function addToast(title: string) {
// setToasts([
// {
// id: '1',
// title,
// color: 'danger'
// }
// ]);
// }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we delete commented code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure I will

}
} catch (error) {
addErrorToast('Error occured while creating organization');
console.log('Error occured', error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets make this either a console.warn or console.error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright....

@tobi-bams
Copy link
Contributor Author

@kevkevinpal made the changes!

@kevkevinpal kevkevinpal merged commit 96987b4 into master Nov 15, 2023
5 checks passed
elraphty pushed a commit that referenced this pull request Jan 26, 2024
* update: updated the UI flow for add organization

* update: image can be dragged and dropped, also new organization can be created

* update: add organization and upload image from browser directly

* fix: fixed file_uploader not returning link

* update: added click on the upload button

* update: styled the org list component properly

* update: reverse a change made earlier
@Evanfeenstra Evanfeenstra deleted the update/create-org-flow branch January 26, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update add new organization modal
3 participants