Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Internal Server Error Middleware with WebSocket Support #2201

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 58 additions & 24 deletions routes/index.go
Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
package routes

import (
"bufio"
"encoding/json"
"fmt"
"io"
"net"
"net/http"
"os"
"time"

"github.com/go-chi/chi"
"github.com/go-chi/chi/middleware"
"github.com/gorilla/websocket"
"github.com/rs/cors"

"github.com/stakwork/sphinx-tribes/auth"
Expand Down Expand Up @@ -63,6 +66,7 @@ func NewRouter() *http.Server {
r.Post("/save", db.PostSave)
r.Get("/save/{key}", db.PollSave)
r.Get("/migrate_bounties", handlers.MigrateBounties)
r.Get("/test/internal-server-error", testInternalServerError)
r.Get("/websocket", handlers.HandleWebSocket)
})

Expand Down Expand Up @@ -141,36 +145,66 @@ func getFromAuth(path string) (*extractResponse, error) {
}, nil
}

// Middleware to handle InternalServerError
// func internalServerErrorHandler(next http.Handler) http.Handler {
// return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
// rr := &responseRecorder{ResponseWriter: w, statusCode: http.StatusOK}
// next.ServeHTTP(rr, r)

// if rr.statusCode == http.StatusInternalServerError {
// fmt.Printf("Internal Server Error: %s %s\n", r.Method, r.URL.Path)
// http.Error(w, http.StatusText(http.StatusInternalServerError), http.StatusInternalServerError)
// }
// })
// }

// Custom ResponseWriter to capture status codes
// type responseRecorder struct {
// http.ResponseWriter
// statusCode int
// }

// func (rr *responseRecorder) WriteHeader(code int) {
// rr.statusCode = code
// rr.ResponseWriter.WriteHeader(code)
// }
type responseRecorder struct {
http.ResponseWriter
statusCode int
written bool
}

func (rr *responseRecorder) WriteHeader(code int) {
if !rr.written {
rr.statusCode = code
rr.written = true
rr.ResponseWriter.WriteHeader(code)
}
}

func (rr *responseRecorder) Write(b []byte) (int, error) {
if !rr.written {
rr.statusCode = http.StatusOK
rr.written = true
}
return rr.ResponseWriter.Write(b)
}

func (rr *responseRecorder) Hijack() (net.Conn, *bufio.ReadWriter, error) {
if hijacker, ok := rr.ResponseWriter.(http.Hijacker); ok {
return hijacker.Hijack()
}
return nil, nil, fmt.Errorf("hijacking not supported")
}

func internalServerErrorHandler(next http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {

if websocket.IsWebSocketUpgrade(r) {
next.ServeHTTP(w, r)
return
}

rr := &responseRecorder{
ResponseWriter: w,
statusCode: http.StatusOK,
written: false,
}

next.ServeHTTP(rr, r)

if rr.statusCode == http.StatusInternalServerError {
fmt.Printf("Inside Internal Server Middleware: %s %s\n", r.Method, r.URL.Path)
}
})
}

func testInternalServerError(w http.ResponseWriter, r *http.Request) {
http.Error(w, "Internal Server Error", http.StatusInternalServerError)
}
func initChi() *chi.Mux {
r := chi.NewRouter()
r.Use(middleware.RequestID)
r.Use(middleware.Logger)
r.Use(middleware.Recoverer)
// r.Use(internalServerErrorHandler)
r.Use(internalServerErrorHandler)
cors := cors.New(cors.Options{
AllowedOrigins: []string{"*"},
AllowedMethods: []string{"GET", "POST", "PUT", "DELETE", "OPTIONS"},
Expand Down
Loading