Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Internal Server Error Middleware with WebSocket Support #2201

Conversation

aliraza556
Copy link
Contributor

Describe your changes

Issue ticket number and link: #2199

Closed: #2199

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@aliraza556
Copy link
Contributor Author

@kevkevinpal Please review this PR.

@kevkevinpal
Copy link
Contributor

I went ahead and merged this PR #2200 instead but, if you want to modify this PR to just include the new endpoint to cause a 500 error so we can test we can use that

@aliraza556
Copy link
Contributor Author

if you want to modify this PR to just include the new endpoint to cause a 500 error so we can test we can use that

@kevkevinpal Sure.

@aliraza556 aliraza556 marked this pull request as draft December 16, 2024 20:26
@kevkevinpal
Copy link
Contributor

going to close this PR since these changes are no longer needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web socket failure on InternalServerMiddleware
2 participants