Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated IncrementInstanceEnabled property #6001

Closed
wants to merge 2 commits into from
Closed

Remove deprecated IncrementInstanceEnabled property #6001

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49f4183
Remove deprecated IncrementInstanceEnabled property
cppwfs Oct 16, 2024
7c50c0a
Updated based on code review.
cppwfs Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .../java/org/springframework/cloud/dataflow/composedtaskrunner/ComposedRunnerJobFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,9 @@ public Job getObject() throws Exception {
.start(createFlow())
.end())
.end();
builder.incrementer(new UuidIncrementer());
if(this.composedTaskProperties.isUuidInstanceEnabled()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TinyNit] I am not sure if our formatter needs updating, but I am suprised it is not balking about space after if.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will polish. Thanks for noticing!

builder.incrementer(new UuidIncrementer());
}
return builder.build();
}

Expand Down
4 changes: 2 additions & 2 deletions .../springframework/cloud/dataflow/composedtaskrunner/properties/ComposedTaskProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,10 +191,10 @@ public class ComposedTaskProperties {
/**
* Allows a single ComposedTaskRunner instance to be re-executed without
* changing the parameters. It does this by applying a {@code run.id} with a UUid.
* Default is false.
* Default is true.
* Set this option to `true` when running multiple instances of the same composed task definition at the same time.
*/
private boolean uuidInstanceEnabled = false;
private boolean uuidInstanceEnabled = true;

/**
* The platform property that will be used for each task in the workflow when it is launched.
Expand Down
2 changes: 1 addition & 1 deletion ...ngframework/cloud/dataflow/composedtaskrunner/properties/ComposedTaskPropertiesTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ void gettersAndSetters() throws URISyntaxException{
assertThat(properties.getDataflowServerPassword()).isEqualTo("bar");
assertThat(properties.getDataflowServerAccessToken()).isEqualTo("foobar");
assertThat(properties.isSkipTlsCertificateVerification()).isTrue();
assertThat(properties.isUuidInstanceEnabled()).isFalse();
assertThat(properties.isUuidInstanceEnabled()).isTrue();
properties.setUuidInstanceEnabled(true);
assertThat(properties.isUuidInstanceEnabled()).isTrue();
}
Expand Down
Loading