Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated IncrementInstanceEnabled property #6001

Closed
wants to merge 2 commits into from

Conversation

cppwfs
Copy link
Contributor

@cppwfs cppwfs commented Oct 21, 2024

uuidInstanceEnabled is the updated property

Verified

This commit was signed with the committer’s verified signature.
cppwfs Glenn Renfro
uuidInstanceEnabled is the updated property
@cppwfs cppwfs requested a review from onobc October 21, 2024 20:59
else if(this.composedTaskProperties.isUuidInstanceEnabled()) {
builder.incrementer(new UuidIncrementer());
}
builder.incrementer(new UuidIncrementer());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be guarded by this.composedTaskProperties.isUuidInstanceEnabled() ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely. And the default of the isUuidInstanceEnabled needs to be set to true.
GREAT CATCH!

Copy link
Contributor

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup @cppwfs . Couple of small comments/suggestions.

Verified

This commit was signed with the committer’s verified signature.
cppwfs Glenn Renfro
* Guard adding incrementer to the job with the isUuiIdInstanceEnabled
* Set uuideInstanceEnabled to true by default since it is now the default incrementer
@@ -109,7 +109,9 @@ public Job getObject() throws Exception {
.start(createFlow())
.end())
.end();
builder.incrementer(new UuidIncrementer());
if(this.composedTaskProperties.isUuidInstanceEnabled()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TinyNit] I am not sure if our formatter needs updating, but I am suprised it is not balking about space after if.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will polish. Thanks for noticing!

Copy link
Contributor

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @cppwfs !

@cppwfs
Copy link
Contributor Author

cppwfs commented Oct 22, 2024

@onobc Thank you for the great review!

Polished, Squashed, Rebased, Merged.

@cppwfs cppwfs closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants