-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift-driver integration, Part II: add Swift front-end parsing stage #209
Conversation
d491cb5
to
338cbd1
Compare
file: primaryInputFilesURLs[i], | ||
dependencies: dependenciesPaths.get(i).map(URL.init(fileURLWithPath:)), | ||
object: outputPaths.get(i).map(URL.init(fileURLWithPath:)), | ||
// for now - swift-dependencies are not requested in the driver compilation mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at least I have never seen that
} | ||
|
||
override public func run() throws { | ||
// TODO: implement in a follow-up PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be added separately to keep this PR small(er)
|
||
func run(criticalSection: () throws -> Void) throws { | ||
// TODO: implement synchronization in a separate PR | ||
try criticalSection() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be added separately to keep this PR small(er)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some typos. Looks great!
@@ -279,6 +286,7 @@ struct ConfigFileScheme: Decodable { | |||
let customRewriteEnvs: [String]? | |||
let irrelevantDependenciesPaths: [String]? | |||
let gracefullyHandleMissingCommonSha: Bool? | |||
let enableSwifDriverIntegration: Bool? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let enableSwifDriverIntegration: Bool? | |
let enableSwiftDriverIntegration: Bool? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same in others. 👀
// -target is required | ||
case emitMissingTarget | ||
// -moduleName is required | ||
case emiMissingModuleName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
case emiMissingModuleName | |
case emitMissingModuleName |
Part II (out of IV) of the swift driver integration:
xcswift-frontend
wrapper that parses input parameters and stores them into the structured module (struct
)enable_swift_driver_integration
config that will enable the driver integrationXCSwiftFrontend
andSwiftFrontendOrchestrator
that are no-op for now, but in a follow-up PR will add swift-frontend processes synchronizationPrevious PR: #208