[SwiftDriverIntegraiton] Part IV: Add E2E tests for the swift driver integration #5 #212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last part of the Swift integration support
xcswift-frontent
to the .zip (incl. theswift-frontend
->xcswift-frontend
andswiftc
->xcswiftc
symbolic links). Symlinks are added because Xcode's driver integration requires that theSWIFT_EXEC
hasswiftc
filename, placed next to theswift-frontent
enable_swift_driver_integration: true
in the CocoaPods plugin (the automatic integration already support that, added Refactor existing implementation for swift-driver change #208)enable_swift_driver_integration
. That makes the E2E testing longer (~x2), but in the near future (when Xcode 14 support will be deprecated) we will be able to delete the legacy testing. Until we stabilize Swift Driver Integration, E2E tests will take more time. In a single CI, it seems the test pipeline takes 22min (vs 14m previously).arm64
). As M1 machines are already more popular than Intel machines, it is better to cover that architecture in tests.Previous PRs: #208, #209, #210