-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support exposing enums from ObjC via Bridging headers #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polac24
changed the title
20220606 publish swifth md5
Support exposing enums from ObjC via Bridging headers
Jun 6, 2022
PatrikBillgren
previously approved these changes
Jun 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Approved, I just noticed one minor nit in a comment
Co-authored-by: PatrikBillgren <[email protected]>
@PatrikBillgren, can you please reapprove after my typo fix? |
CognitiveDisson
approved these changes
Aug 24, 2022
@polac24 Should we merge it? |
@CognitiveDisson, yes. let me merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part III (out of IV) of #140 fix
-Swift.h
and-Swift.h.md5
. Because the former could contain absolute paths, the latter file is used in a dependency fingerprint (just like.swiftmodule
files) - its content is just the same as the .swiftmodule's override (a fingerprint of the target).h
dependency, check if an override is available. If so, its content is used for the fingerprint-Swift.h.md5
is automatically placed next to the-Swift.h
only for a .framework, a developer that wants to cover that for a static library, has to manually add an extraditto
(similar tocp
) build step to move-Swift.h.md5
along-Swift.h
. Required steps are documented in Readme.md. This scenario can be considered (only static library + exposing enum via a bridging header) as an edge case - very unlikely to happen.This part unblocks
rake e2e:run_standalone
added in #147.