Make PUBLIC_HEADERS_FOLDER_PATH ENV optional #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polac24
force-pushed
the
20220831-optional-public-headers-folder
branch
from
aaaaed0 to
b1507b6
Compare
acbdev
approved these changes
Nov 18, 2022
|
Hi @acbdev, thanks for the review. Do you if getting a write-access to the repo is an automated process? Seems you are not added to the group so github still reports that a review is required. |
PatrikBillgren
approved these changes
Nov 23, 2022
|
Yay! Seems that all is set up correctly, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #163,
PUBLIC_HEADERS_FOLDER_PATHintroduced in #149 is not always available - e.g. when CocoaPods build a static library. For a CocoaPods scenario, take a look on the sourcecode here and note that when a Build Setting is set to an empty string, a build phase script is called without that ENV.In such a case, we don't have to automatically rewrite generated
-Swift.hfile. To skip the rewriting step (introduced in #149) we can leavepublicHeadersFolderPathasnil.The original issue (#149) reports that this problem is caused only when a static library is used (not frameworks).
Fixes #163