Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E test for exposing public enums from ObjC to Swift #147

Merged

Conversation

polac24
Copy link
Collaborator

@polac24 polac24 commented Jun 6, 2022

Part I of fixing #140 - E2E test that covers a scenario reported in the issue:

  • Mixed target (ObjC+Swift) exposes an enum defined in ObjC (using NS_ENUM)
  • Swift API uses that enum in the public API (using Bridging header) so -Swift.h contains an absolute path to the Bridging header.
  • XCRemoteCache stores a plain -Swift.h content in an artifact, the build may fail if a local machine has a different absolute SRCROOT than the producer
  • To emulate different SRCROOT machines, E2E test temporarily moves the directory of e2eTests/StandaloneSampleApp

This Standalone test is failing (as expected, the fix will be added in separate PRs) - for now, CI does not invoke it.
To run it locally, call rake e2e:run_standalone

This PR contains 2 changes/fixes to the E2E tests:

  • prints xcodebuild output to the std - that could simplify troubleshooting CI errors
  • small fix in valide_hit_rate

@polac24 polac24 merged commit 00cb8cc into spotify:master Jun 7, 2022
@polac24 polac24 deleted the 20220606-bridging-headers-enum-test branch June 7, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants