Use stream_socket_client() exception for better message #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freekmurze
requested changes
Oct 3, 2023
src/Downloader.php
Outdated
| $streamContext | ||
| ); | ||
| } | ||
| catch (\ErrorException $ex) { |
There was a problem hiding this comment.
Could you import this, so we can lose the \. Also rename $ex to $exception.
|
Crap. I missed this. I made the changes and forgot to push 🤦 Voila. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stream_socket_client()'s$errorDescriptionmisses a lot of error message. Most of the time (in my cases) it's just an empty string after a connection failure. But the exception is always a useful pretty error message.hostDoesNotExist,noCertificateInstalledandunknownErrorafter that still work the same.