Use stream_socket_client() exception for better message (#183)

* Use stream_socket_client() exception for better message * catch exception better
spatie · Oct 17, 2023 · 3d6c876 · 3d6c876
1 parent f08600f
commit 3d6c876
Showing 1 changed file with 15 additions and 8 deletions.
diff --git a/src/Downloader.php b/src/Downloader.php
@@ -2,6 +2,7 @@
 
 namespace Spatie\SslCertificate;
 
+use ErrorException;
 use Spatie\SslCertificate\Exceptions\CouldNotDownloadCertificate;
 use Spatie\SslCertificate\Exceptions\InvalidIpAddress;
 
@@ -180,14 +181,20 @@ protected function fetchCertificates(string $hostName): array
             $connectTo = $hostName;
         }
 
-        $client = @stream_socket_client(
-            "ssl://{$connectTo}:{$this->port}",
-            $errorNumber,
-            $errorDescription,
-            $this->timeout,
-            STREAM_CLIENT_CONNECT,
-            $streamContext
-        );
+        try {
+            $client = stream_socket_client(
+                "ssl://{$connectTo}:{$this->port}",
+                $errorNumber,
+                $errorDescription,
+                $this->timeout,
+                STREAM_CLIENT_CONNECT,
+                $streamContext
+            );
+        }
+        catch (ErrorException $exception) {
+            $client = null;
+            $errorDescription = trim(str_replace('stream_socket_client():', '', $exception->getMessage()));
+        }
 
         if (! empty($errorDescription)) {
             throw $this->buildFailureException($connectTo, $errorDescription);