JP-3583: Long integrations truncation in ramp fitting #251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3583
Closes spacetelescope/jwst#8373
This PR addresses an issue in the ramp_fitting routine where when finding the cosmic ray free segments of integrations. The code accumulates the non-CR groups using a counter. The problem is that this counter is a uint8 data type. Thus, once we get above 256 groups, it rolls over leading to only using a subset of the groups in the slope fit.
The solution was to change three variables from UINT8 to UINT16. This is big enough given the overall limit on the number of frames.
Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)