JP-3436 Empty wavelength array in s2d products

[penaguerrero]

Resolves JP-3436

Closes #7994

This PR populates the wavelength array in the s2d files.

Checklist for maintainers

• added entry in CHANGES.rst within the relevant release section
• updated or added relevant tests
• updated relevant documentation
• added relevant milestone
• added relevant label(s)
• ran regression tests, post a link to the Jenkins job below.
  How to run regression tests on a PR
• Make sure the JIRA ticket is resolved properly

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.39%. Comparing base (6580914) to head (438a9d3).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #8374   +/-   ##
=======================================
  Coverage   56.38%   56.39%           
=======================================
  Files         387      387           
  Lines       38716    38723    +7     
=======================================
+ Hits        21830    21837    +7     
  Misses      16886    16886           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[penaguerrero]

running reg tests: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1332/

[hbushouse]

@nden Need your expert insight as to whether this will have the desired effect.

[nden]

The code looks good to me but don't take my word for it. It won't hurt to add tests verifying that the wavelength array is identical to the computed one. The miri slit test can go in test_miri_lrs_slit_spec3 or in a separate test.
Similarly for the other modes.
The regression test run has many failures possibly due to other changes. It's also not very informative because FITS changes the order of extensions so there's no real comparison. We need a fresh run.

[penaguerrero]

I checked the MIRI LRS truth and as of now it has a wavelength array of all zeros, same with the NRS data. I can add these tests for the future, but for now I think we'll have to "okayfy" them?

[nden]

What I meant is adding a test to check in all modes that model.wavelength is close enough to a computed_wavelength array, where computed_wavelength=WCS(x,y)[2].

[penaguerrero]

reg test running: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1402/

[hbushouse]

Something's causing errors in the CI style check:

jwst/regtest/test_miri_lrs_slit_spec3.py:90:21: F821 Undefined name `slit`
jwst/regtest/test_nirspec_fs_spec3.py:57:21: F821 Undefined name `slit`
jwst/regtest/test_nirspec_mos_spec3.py:49:17: F821 Undefined name `slit`

[nden]

Failures were fixed in #8456
Regression test run started: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1416/

[hbushouse]

CI tests are passing and all the failures in the last regtest run appear to simply be due to the presence of the WAVELENGTH extension in s2d products, which wasn't there before. So I think everything looks good (?)