-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove global multiprocessing.set_start_method #8343
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8343 +/- ##
==========================================
+ Coverage 75.31% 75.77% +0.46%
==========================================
Files 474 476 +2
Lines 38965 39448 +483
==========================================
+ Hits 29345 29891 +546
+ Misses 9620 9557 -63
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e6944ee
to
a443917
Compare
Regtests run at: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1310/ |
a443917
to
ec410ea
Compare
ec410ea
to
d37b0f2
Compare
Note: prior to merge the dev dependency on stcal should be removed. |
The 3.9 and oldestdeps failures look like they'd be addressed in: |
@emolter this PR has some minor overlap with #8417 I gave #8417 a skim and it looks like it would make the wfss changes in this PR unecessary. However this PR has additional related changes in |
55f864d
to
18344af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good to me. Are there any regtests that test the multiprocessing modes for these steps? Not sure what that would even look like...
RE my PR for the wfss_contam step, I think it's completely fine to merge this right away. It will be a while before that PR gets merged as there are lots of outstanding issues.
Thanks for taking a look!
Not that I'm aware of. The main motivation for adding the
Good to know. Let me if there's anything I can do to help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Is everyone else happy?
Fixes: #8306
Without setting a multiprocessing start method (using the default) on linux with python 3.12 results in a
DeprecationWarning
.Warnings for python 3.12:
This is due to
fork
being unsafe for applications that use threads. This warning was previously silenced using a globalset_start_method
which can cause issues for other packages (see #8306).stcal (which is the primary user of multiprocessing in the pipeline) was updated:
spacetelescope/stcal#249
This PR temporarily uses stcal main (that can be removed prior to merge or after a stcal release is made) to pick up the changes in the above PR and updates the remaining multiprocessing usage in wfss_contam to only setEDIT: stcal 1.7.0 (now the required version) contains the required changesforkserver
in a context (to not impact other packages).