Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-2980 Documentation improvement for multiprocessing: a script which spawns processes on import will cause system failure #8408

Merged
merged 19 commits into from
Apr 22, 2024

Conversation

penaguerrero
Copy link
Contributor

@penaguerrero penaguerrero commented Apr 2, 2024

Resolves JP-2980

Closes #7308

This PR addresses needed documentation requested in several help desk tickets. This is connected to GitHub issues:
#8404
#8306

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@penaguerrero penaguerrero requested a review from a team as a code owner April 2, 2024 20:14
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.76%. Comparing base (2fb073e) to head (1baa4c8).
Report is 36 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8408      +/-   ##
==========================================
+ Coverage   75.31%   75.76%   +0.45%     
==========================================
  Files         474      476       +2     
  Lines       38965    39404     +439     
==========================================
+ Hits        29345    29854     +509     
+ Misses       9620     9550      -70     
Flag Coverage Δ *Carryforward flag
nightly 77.64% <ø> (+0.31%) ⬆️ Carriedforward from ccfa560

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGES.rst Outdated Show resolved Hide resolved
docs/jwst/user_documentation/running_pipeline_python.rst Outdated Show resolved Hide resolved
docs/jwst/user_documentation/running_pipeline_python.rst Outdated Show resolved Hide resolved
docs/jwst/user_documentation/running_pipeline_python.rst Outdated Show resolved Hide resolved
docs/jwst/user_documentation/running_pipeline_python.rst Outdated Show resolved Hide resolved
docs/jwst/user_documentation/running_pipeline_python.rst Outdated Show resolved Hide resolved
@hbushouse hbushouse added this to the Build 11.0 milestone Apr 15, 2024
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked the docs built from the CI test in this PR and they look good.

@hbushouse hbushouse merged commit b4c490b into spacetelescope:master Apr 22, 2024
27 of 28 checks passed
@hbushouse
Copy link
Collaborator

@penaguerrero Does this also close #8404 or is it just related?

@penaguerrero
Copy link
Contributor Author

it is not related. In a conversation with Brett we discussed that a cause for the memory issue could be the multiple re-openings of datamodels. He is looking into that separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants