Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#6861]TeamsSSOTokenExchangeMiddleware.DeduplicatedTokenExchangeIdAsync fails on BlobStorage ETag validation #590

Closed
wants to merge 2 commits into from
Closed

fix: [#6861]TeamsSSOTokenExchangeMiddleware.DeduplicatedTokenExchangeIdAsync fails on BlobStorage ETag validation #590

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01004af
add catch to capture 412 error in BlobsStorage
JhontSouth Nov 11, 2024
ea89182
use HttpStatusCode
JhontSouth Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions libraries/Microsoft.Bot.Builder.Azure.Blobs/BlobsStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,11 @@ internal BlobsStorage(BlobContainerClient containerClient, JsonSerializer jsonSe
$"An error occurred while trying to write an object. The underlying '{BlobErrorCode.InvalidBlockList}' error is commonly caused due to concurrently uploading an object larger than 128MB in size.",
ex);
}
catch (RequestFailedException ex)
when (ex.Status == 412)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
when (ex.Status == 412)
when (ex.Status == (int)HttpStatusCode.PreconditionFailed)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

{
throw new InvalidOperationException($"Etag conflict: {ex.Message}");
}
}
}

Expand Down
Loading