fix: [#6861]TeamsSSOTokenExchangeMiddleware.DeduplicatedTokenExchangeIdAsync fails on BlobStorage ETag validation #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceciliaavila
requested changes
Nov 11, 2024
| @@ -290,6 +290,11 @@ internal BlobsStorage(BlobContainerClient containerClient, JsonSerializer jsonSe | |||
| $"An error occurred while trying to write an object. The underlying '{BlobErrorCode.InvalidBlockList}' error is commonly caused due to concurrently uploading an object larger than 128MB in size.", | |||
| ex); | |||
| } | |||
| catch (RequestFailedException ex) | |||
| when (ex.Status == 412) | |||
There was a problem hiding this comment.
Suggested change
| when (ex.Status == 412) | |
| when (ex.Status == (int)HttpStatusCode.PreconditionFailed) |
ceciliaavila
approved these changes
Nov 11, 2024
sw-joelmut
approved these changes
Nov 11, 2024
|
Promoted /6867 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # 6861
#minor
Description
This PR adds the 412 error capture of the BlobsStorage to be handled by TeamsSSOTokenExchangeMiddleware.
Specific Changes
Testing
The following image shows the error being captured.
