-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Redux Toolkit part 9 #2989
Merged
Merged
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7515204
Migrate GitHubPersistenceSaga to use helper
RichDom2185 198a6bd
Use default import for SessionActions in components
RichDom2185 9b80683
Use default import for more files
RichDom2185 76b2367
Use default import in SessionsReducer
RichDom2185 4a56145
Use default import in BackendMocks
RichDom2185 89b07bf
Update tests to use default import
RichDom2185 97fb802
Remove named export for session action creators
RichDom2185 34a30d6
Fix format
RichDom2185 270213a
Remove named export for GitHub action creators
RichDom2185 63920e3
Migrate SourcereelReducer to RTK
RichDom2185 ef623c1
Migrate SourcecastReducer to RTK
RichDom2185 c3d5ff3
Migrate CommonsReducer to RTK
RichDom2185 fe7c3d9
Use namespace import in new reducers
RichDom2185 7b9dcc4
Use default import for InterpreterActions exports
RichDom2185 f51111f
Remove named exports for InterpreterActions
RichDom2185 2422a1e
Use default import in WorkspaceReducer and test
RichDom2185 0ce8ee1
Merge branch 'master' of https://github.com/source-academy/frontend i…
RichDom2185 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sayomaki @chownces Just wanted to check if you're agreeable to removing the named exports to favour the default exports (and fully qualified names).