-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Redux Toolkit part 9 #2989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SessionActions
seems quite large and cross-cutting. Perhaps we can consider splitting it up into multiple actions with well-defined names. But that can be done in another PR too. We can add an issue to track it in the meantime
Done in #2992. |
This is to ease the migration in future PRs where the named exports for action creators are removed.
Removes all direct external references of the action creators, replacing their direct references with fully qualified names from the default export.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through the changes one more time and looks good, thanks!
Description
To rebase and merge onto
master
once #2988 is merged.Mainly a PR to clean up things, but also migrated to RTK for Sourcecast and Sourcereel reducers.
Removes the compatibility layer of having named exports for every action creator. This forces callers to use the default export (and also fully qualified names) of the actions they want to dispatch. Hopefully, this will reduce the chances of any name conflicts, and also enforce better abstractions and grouping of the individual actions. Currently, I feel that some action creators don't belong in the correct file. By forcing the usage of the fully qualified name (especially as the number of actions keeps increasing), people might think twice before putting an action creator inside a specific file.
Technically a breaking change.
Type of change
How to test
I just changed the imports, without any implementation change (except for the migration of
GitHubPersistenceSaga
to use the new helper) – so it should be a non-issue.Checklist