-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 커피챗 등록 유저들 리스트 조회 API - #435 #448
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4d2de4f
[feat] playground coffee chat reponse dto 생성 (#435)
rlarlgnszx b215793
[feat] CoffeeChatList 반환 API (#435)
rlarlgnszx 8d80a34
[feat] coffeeChatList 반환 API (#435)
rlarlgnszx 6683d84
[del] 필요없는 데이터 제거 (#435)
rlarlgnszx 100df47
Merge branch 'dev' into feat/#435
rlarlgnszx 7a1d781
Merge branch 'dev' into feat/#435
rlarlgnszx 3334d5a
[fix] requestParam추가 (#435)
rlarlgnszx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
src/main/java/org/sopt/app/application/playground/dto/PlayGroundCoffeeChatResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
package org.sopt.app.application.playground.dto; | ||
|
||
import java.util.List; | ||
|
||
public record PlayGroundCoffeeChatResponse( | ||
Long memberId, | ||
String bio, | ||
List<String> topicTypeList, | ||
String profileImage, | ||
String name, | ||
String career, | ||
String organization, | ||
String companyJob, | ||
List<String> soptActivities, | ||
boolean isMine, | ||
boolean isBlind | ||
) { | ||
} |
10 changes: 10 additions & 0 deletions
10
src/main/java/org/sopt/app/application/playground/dto/PlayGroundCoffeeChatWrapper.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package org.sopt.app.application.playground.dto; | ||
|
||
import com.fasterxml.jackson.annotation.JsonProperty; | ||
import java.util.List; | ||
|
||
public record PlayGroundCoffeeChatWrapper( | ||
@JsonProperty("coffeeChatList") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Q. 이거 사용하신 이유가 있나요? 알아서 coffeeChatList로 네이밍 되는 것으로 알아서요! |
||
List<PlayGroundCoffeeChatResponse> coffeeChatList | ||
) { | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
src/main/java/org/sopt/app/presentation/home/response/CoffeeChatResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
package org.sopt.app.presentation.home.response; | ||
|
||
import java.util.List; | ||
import lombok.Builder; | ||
import lombok.Getter; | ||
import org.sopt.app.application.playground.dto.PlayGroundCoffeeChatResponse; | ||
|
||
@Getter | ||
@Builder | ||
public class CoffeeChatResponse { | ||
private Long memberId; | ||
private String bio; | ||
private List<String> topicTypeList; | ||
private String profileImage; | ||
private String name; | ||
private String career; | ||
private String organization; | ||
private String companyJob; | ||
private List<String> soptActivities; | ||
|
||
public static CoffeeChatResponse of(PlayGroundCoffeeChatResponse playGroundCoffeeChatResponse){ | ||
return CoffeeChatResponse.builder() | ||
.memberId(playGroundCoffeeChatResponse.memberId()) | ||
.bio(playGroundCoffeeChatResponse.bio()) | ||
.topicTypeList(playGroundCoffeeChatResponse.topicTypeList()) | ||
.profileImage(playGroundCoffeeChatResponse.profileImage()) | ||
.name(playGroundCoffeeChatResponse.name()) | ||
.career(playGroundCoffeeChatResponse.career()) | ||
.organization(playGroundCoffeeChatResponse.organization()) | ||
.companyJob(playGroundCoffeeChatResponse.companyJob()) | ||
.soptActivities(playGroundCoffeeChatResponse.soptActivities()) | ||
.build(); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: 저번 PR에서 놓쳤는데 16, 10, 0이라는 부분이 알아보기 어렵기도 하고 너무 많은 변수를 가지고 있는 것 같아요.
DTO로 묶거나, 필드로 사용해서 이름을 명시하거나 하는게 좋을 것 같다 생각됩니다!