[FEAT] 커피챗 등록 유저들 리스트 조회 API - #435 #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kseysh
approved these changes
Nov 14, 2024
Comment on lines
19
to
26
| import org.sopt.app.application.playground.dto.PlaygroundProfileInfo.ActiveUserIds; | ||
| import org.sopt.app.application.playground.dto.PlaygroundProfileInfo.ActivityCardinalInfo; | ||
| import org.sopt.app.application.playground.dto.PlaygroundProfileInfo.MainView; | ||
| import org.sopt.app.application.playground.dto.PlaygroundProfileInfo.MainViewUser; | ||
| import org.sopt.app.application.playground.dto.PlaygroundProfileInfo.OwnPlaygroundProfile; | ||
| import org.sopt.app.application.playground.dto.PlaygroundProfileInfo.PlaygroundMain; | ||
| import org.sopt.app.application.playground.dto.PlaygroundProfileInfo.PlaygroundProfile; | ||
| import org.sopt.app.application.playground.dto.PlaygroundProfileInfo.UserActiveInfo; |
Comment on lines
9
to
11
| import java.util.Collections; | ||
| import java.util.List; | ||
| import java.util.Map; |
There was a problem hiding this comment.
Q. lombok과 util에서 와일드카드 사용안하시는 이유가 있으실까요?
| @@ -166,7 +181,14 @@ public List<EmploymentPostResponse> getPlaygroundEmploymentPost(String accessTok | |||
| PlayGroundEmploymentResponse postInfo = playgroundClient.getPlaygroundEmploymentPost(requestHeader,16,10,0); | |||
There was a problem hiding this comment.
P3: 저번 PR에서 놓쳤는데 16, 10, 0이라는 부분이 알아보기 어렵기도 하고 너무 많은 변수를 가지고 있는 것 같아요.
DTO로 묶거나, 필드로 사용해서 이름을 명시하거나 하는게 좋을 것 같다 생각됩니다!
| import java.util.List; | ||
|
|
||
| public record PlayGroundCoffeeChatWrapper( | ||
| @JsonProperty("coffeeChatList") |
There was a problem hiding this comment.
Q. 이거 사용하신 이유가 있나요? 알아서 coffeeChatList로 네이밍 되는 것으로 알아서요!
혹시 창업 커리어 이 뱃지 부분은 응답에서 topicTypeList 부분이 맞나요?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 PR Summary
🌴 Works
🌱 Related Issue
closed #435
🌵 PR 참고사항