Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coretasks, test: handle core.modes setting being None #2510

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

dgw
Copy link
Member

@dgw dgw commented Sep 24, 2023

Description

Tin. Also added None to tested cases, so if it goes back to throwing an error after future changes we'll find out about it.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make lint and make test)
  • I have tested the functionality of the things this change touches

Notes

Fun facts about this bug:

  • It was introduced in core: better bot-mode handling #2448 (my fault).
  • I considered giving core.modes a default='', but it could still become None if someone puts modes = into their config file. The logic changes here would still be required to handle that case, so I decided that None was still a more semantic "not set" value than empty-string and left it without a default value.

Add `None` to tested cases, as well, so if it goes back to throwing an
error after future changes we'll find out about it.
@dgw dgw added Bugfix Generally, PRs that reference (and fix) one or more issue(s) Core/IRC Protocol Handling labels Sep 24, 2023
@dgw dgw added this to the 8.0.0 milestone Sep 24, 2023
@dgw dgw requested a review from a team September 24, 2023 23:17
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Should have been more careful when reviewing last time!

@dgw dgw merged commit 953f2eb into master Sep 26, 2023
7 checks passed
@dgw dgw deleted the core.modes=None branch September 26, 2023 11:19
@dgw dgw linked an issue Sep 26, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s) Core/IRC Protocol Handling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unspecified modes parameter leads to confusing error
3 participants