coretasks, test: handle core.modes
setting being None
#2510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tin. Also added
None
to tested cases, so if it goes back to throwing an error after future changes we'll find out about it.Checklist
make qa
(runsmake lint
andmake test
)test/test_coretasks.py::test_handle_isupport_bot_mode[None]
initially failed with an exception traceback, as described in Unspecifiedmodes
parameter leads to confusing error #2509.With the patch applied, it passes.
Notes
Fun facts about this bug:
core.modes
adefault=''
, but it could still becomeNone
if someone putsmodes =
into their config file. The logic changes here would still be required to handle that case, so I decided thatNone
was still a more semantic "not set" value than empty-string and left it without a default value.