Merge pull request #2510 from sopel-irc/core.modes=None

coretasks, test: handle `core.modes` setting being `None`

sopel/coretasks.py

@@ -463,15 +463,19 @@ def handle_isupport(bot, trigger):
     if not botmode_support and 'BOT' in bot.isupport:
         # yes it was! set our mode unless the config overrides it
         botmode = bot.isupport['BOT']
-        if botmode not in bot.config.core.modes:
+        modes_setting = bot.config.core.modes
+
+        if not modes_setting or botmode not in bot.config.core.modes:
             bot.write(('MODE', bot.nick, '+' + botmode))
+
     # was NAMESX support status updated?
     if not namesx_support and 'NAMESX' in bot.isupport:
         # yes it was!
         if not bot.capabilities.is_enabled('multi-prefix'):
             # and the multi-prefix capability is not enabled
             # so we can ask the server to use the NAMESX feature
             bot.write(('PROTOCTL', 'NAMESX'))
+
     # was UHNAMES support status updated?
     if not uhnames_support and 'UHNAMES' in bot.isupport:
         # yes it was!

test/test_coretasks.py

@@ -361,7 +361,7 @@ def test_handle_isupport_chantypes(mockbot):
     assert mockbot.make_identifier('!channel').is_nick()
 
 
-@pytest.mark.parametrize('modes', ['', 'Rw'])
+@pytest.mark.parametrize('modes', [None, '', 'Rw'])
 def test_handle_isupport_bot_mode(mockbot, modes):
     mockbot.config.core.modes = modes