Move 'shipping_preference' preference under PaypalOrder#to_json #152
Conversation
|
Cleanup of #134. @DanielePalombo I tried to cleanup the git history at the best I could. |
| end | ||
|
|
||
| def require_shipping? | ||
| step_names = @order ? @order.checkout_steps : ::Spree::Order.checkout_steps.keys |
There was a problem hiding this comment.
Hi @retsef 👋
@order.checkout_steps returns strings
::Spree::Order.checkout_steps.keys returns symbols
Meaning step_names.include? 'delivery' will always return false for the latter.
It would also be nice to move step_names to another private method:
def step_names
@order ? @order.checkout_steps.map(&:to_sym) : ::Spree::Order.checkout_steps.keys
end
|
This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions. |
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
…ddress is returned when order don't include 'delivery' step (cherry picked from commit ff5aa22)
|
@retsef sorry that stalebot closed this, I reopened and rebased, this is a much needed fix! 🙌 |
Fix #133 shipping_preference with 'NO_SHIPPING' is now provided under PaypalOrder#to_json, otherwise 'SET_PROVIDED_ADDRESS'