simplify require_shipping? check in PaypalOrder with separated step_n…

…ames method
solidusio · Dec 23, 2021 · 26491c9 · 26491c9
1 parent ff773eb
commit 26491c9
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/app/models/solidus_paypal_commerce_platform/paypal_order.rb b/app/models/solidus_paypal_commerce_platform/paypal_order.rb
@@ -129,9 +129,11 @@ def application_context
     end
 
     def require_shipping?
-      step_names = @order ? @order.checkout_steps : ::Spree::Order.checkout_steps.keys
+      step_names.include? :delivery
+    end
 
-      step_names.include? 'delivery'
+    def step_names
+      @order ? @order.checkout_steps.map(&:to_sym) : ::Spree::Order.checkout_steps.keys
     end
 
     def greater_than_2_10?