-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bolt as a Payment Method Option #4425
Add Bolt as a Payment Method Option #4425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @piyushswain!
I left a comment. Also, if you rebase from master CI will be green.
@@ -148,6 +137,21 @@ def install_payment_method | |||
end | |||
end | |||
|
|||
def install_auth_plugin | |||
# Doesn't need to add solidus_auth_devise if solidus_bolt is being installed as it already has the gem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should rely on a transitive dependency. Although it's unlikely, in the case of solidus_bolt
stopping depending on solidus_auth_devise
, we want the host application to keep using it.
76f458a
to
5fb1b68
Compare
Successfully installed on:
Change required to make in work: config.active_record.yaml_column_permitted_classes = [Symbol] Otherwise got the following error on
|
Failing on:
Related Error:
|
This commit adds bolt as a payment method option during solidus installation.
5fb1b68
to
27ec86f
Compare
It looks like |
@piyushswain can you take care of it? |
As it contains code referencing solidus_frontend, we need to move it to the solidus_frontend installer. |
@waiting-for-dev Could you please explain a little more on why we need to move the bolt installation to the From what I understand solidus installation should install any selected I don't understand the reason why we need to move this to |
Sure, @piyushswain. Sorry for not being clear enough. Since #4490, the Solidus installer prompts the user to select solidus_frontend or solidus_starter_frontend as storefront. The We're now recommending extensions not to add storefront code. We're still missing a discussion about how we should tackle this kind of built-in integration for the new recommended frontend, though. Does it make sense? |
This PR adds bolt as a payment method option during solidus installation.
The
install_generator.rb
file has been updated to addBolt
as an optional payment method during solidus installation.The
Bolt
option in the payment method installs thesolidus_bolt
gem.Ref solidus_bolt#109
Checklist: